search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 388 forks source link

Remove manual dependency to ProtoBuf #68

Closed tisonkun closed 5 years ago

tisonkun commented 5 years ago

This pull request remove the prerequisite that our user have to install protobuf-2.5.0. It uses org.xolstice.maven.plugins's protobuf plugin and retrieve protobuf from maven central.

gosonzhang commented 5 years ago

This configuration business guarantees its own suitability. There are two problems in the modification: the modification should satisfy the requirement of running successfully under windows; how to avoid intrusive modifications to the business environment, such as PB installed in the environment, or other versions of PB, whether this will affect the business environment, and how to provide and feedback conflicts without installation permission.

这个配置业务自己保证更合适，修改存在2个问题: 这个修改要满足在windows下运行成功; 如何避免对业务环境的侵入修改，比如环境已安装PB,或者其它版本PB,这样处理是否会对业务环境造成影响，如果没有安装权限,如何提供并反馈冲突

tisonkun commented 5 years ago

closed as won't do.