search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 388 forks source link

Replace sun.misc.BASE64Encoder with java.util.Base64 #69

Closed tisonkun closed 5 years ago

tisonkun commented 5 years ago

Currently, we use internal class sun.misc.BASE64Encoder inside com.tencent.tubemq.server.broker.BrokerServiceServer. This class cannot be accessed anymore since Java 11. Although we might not have a upgrade plan in the near future, we can safely do the replacement following the existing solution in JDK community.

tisonkun commented 5 years ago

defer until we have a plan to upgrade to Java 11

please do not close this issue since it is valid anyway.

gosonzhang commented 5 years ago

It is better to make the base64 encoding into a utils class.

tisonkun commented 5 years ago

@gosonzhang do you mean we implement a TubeMQ scope Base64 encoder?

gosonzhang commented 5 years ago

see https://github.com/Tencent/TubeMQ/pull/91

ZoranNik91 commented 3 years ago

I have the same error in the build: sun/misc/BASE64Encoder. So you guys recommended replacing java.util.Base64. How do I do this in Eclipse, just adding a jar file library in the build path of the project, or is there more job to do? I'm new to Eclipse...

gosonzhang commented 3 years ago

Hi,

Thanks for your attention first! 

The tencent/tubemq is only an archive of the open source, and the latest version of TubeMQ is already on the Apache incubation project. 

You can refer to the code in the https://github.com/apache/incubator-tubemq directory. Version 0.7.0 is currently being released. It is recommended to use this Best branch code. There are detailed compilation and running documents on the homepage document: https://tubemq.apache.org/en-us/index.html

For Eclipse, sorry, I use IDEA, not sure how to import Eclipse. I think there should be no difference between importing TubeMQ and importing other projects on Eclipse.

------------------ 原始邮件 ------------------ 发件人: "Tencent/TubeMQ" <notifications@github.com>; 发送时间: 2020年11月26日(星期四) 上午8:23 收件人: "Tencent/TubeMQ"<TubeMQ@noreply.github.com>; 抄送: "gosonzhang"<4675739@qq.com>;"State change"<state_change@noreply.github.com>; 主题: Re: [Tencent/TubeMQ] Replace sun.misc.BASE64Encoder with java.util.Base64 (#69)

I have the same error in the build: sun/misc/BASE64Encoder. So you guys recommended replacing java.util.Base64. How do I do this in Eclipse, just adding a jar file library in the build path of the project, or is there more job to do? I'm new to Eclipse...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.