search

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong
https://inlong.apache.org/
2.02k stars 388 forks source link

Improvement `BdbGroupAdmin` class #78

Closed aloyszhang closed 5 years ago

aloyszhang commented 5 years ago

BdbGroupAdmin is used to remove node in replication group. Currently, BdbGroupAdmin does't handle the exception and missing the necessary message about the remove process. I think we should:

  1. print the node information before and after remove node
  2. catch and handler the exception separately, then print some readable information

What do you think @gosonzhang ?

gosonzhang commented 5 years ago

Very good advice, can you contribute a PR?

aloyszhang commented 5 years ago

@gosonzhang I have open a PR here