Replace sun reference with apache commons

Tencent / TubeMQ

TubeMQ has been donated to the Apache Software Foundation and renamed to InLong, please visit the new Apache repository: https://github.com/apache/incubator-inlong

https://inlong.apache.org/

2.02k stars 388 forks source link

Replace sun reference with apache commons #91

Closed ctide closed 5 years ago

ctide commented 5 years ago

Replace reference to sun.misc.BASE64Encoder with org.apache.commons.code.binary.Base64

ctide commented 5 years ago

Is this not working for you in Java 7? This should be a Java 7 compatible change.

tisonkun commented 5 years ago

Related to #69

I think since it use apache-common instead of Java 8 Base64 it is Java 1.7 compatible. @ctide could you share a gist checking that two-way codec are compatible? It would be like https://github.com/Tencent/TubeMQ/pull/70#issuecomment-540014908

ctide commented 5 years ago

https://gist.github.com/ctide/fd516723790d365952c64ac06fce43ee just updating the one in the other comment to use apache commons instead works. I wouldn't want to add the test itself to the project because then you have to bring in the sun libs.

gosonzhang commented 5 years ago

thanks @ctide