VasSonic is a lightweight and high-performance Hybrid framework developed by tencent VAS team, which is intended to speed up the first screen of websites working on Android and iOS platform.
Other
11.8k
stars
1.61k
forks
source link
Remove operation cancelation when stop connection in iOS #266
The comment said fix #253 , I suspect the reason is memory leaks of connection, I make a PR #265 to fix it.
This PR, I removed these cancellation, the reason is delegateQueue could be sonicSessionQueue, it's a global queue, all session related thing do on this queue. And if we don't do cancellation, it not have side-effect, because we already nil the delegate.
The comment said fix #253 , I suspect the reason is memory leaks of connection, I make a
PR#265 to fix it.This
PR, I removed these cancellation, the reason isdelegateQueuecould besonicSessionQueue, it's a global queue, all session related thing do on this queue. And if we don't do cancellation, it not have side-effect, because we alreadynilthedelegate.