Tencent / phxpaxos

The Paxos library implemented in C++ that has been used in the WeChat production environment.
Other
3.35k stars 862 forks source link

Paxos made simple is ambiguous #166

Open joudinet opened 5 years ago

joudinet commented 5 years ago

The author of the article "Paxos made simple" says in his website that this article contains an ambiguous sentence that may lead to incorrect implementations: http://lamport.azurewebsites.net/pubs/pubs.html#paxos-simple

He explicitly says: "Do not try to implement the algorithm from this paper. Use [122] instead." Looking at the README file of this project, I'm concern if you are aware of such ambiguity, and if your implementation is correct?

lynncui00 commented 5 years ago

We learn 《The Part-Time Parliament》 before 《Paxos Made Simple》, so we don't think our implementation is wrong. Of course, it is difficult to achieve 0 bugs in specific implementations, but we have verified on very large scale clusters.

joudinet notifications@github.com 于2019年4月3日周三 下午9:49写道:

The author of the article "Paxos made simple" says in his website that this article contains an ambiguous sentence that may lead to incorrect implementations: http://lamport.azurewebsites.net/pubs/pubs.html#paxos-simple

He explicitly says: "Do not try to implement the algorithm from this paper. Use [122] instead." Looking at the README file of this project, I'm concern if you are aware of such ambiguity, and if your implementation is correct?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Tencent/phxpaxos/issues/166, or mute the thread https://github.com/notifications/unsubscribe-auth/ASn3_F0bmvCtuETk9QyLZrL9w3Usin3Hks5vdLF8gaJpZM4cakM3 .

-- Best Regards, Lynncui