search

Tencent / tinker

Tinker is a hot-fix solution library for Android, it supports dex, library and resources update without reinstall apk.
Other
17.13k stars 3.33k forks source link

add javadoc to a method in tinker/tinker-android/tinker-android-loader/src/main/java/com/tencent/tinker/loader/hotplug/IncrementComponentManager.java #1450

Open 129124 opened 4 years ago

129124 commented 4 years ago

Hi there, when I was reading the code of the function "public static boolean isIncrementActivity(String className)" in tinker/tinker-android/tinker-android-loader/src/main/java/com/tencent/tinker/loader/hotplug/IncrementComponentManager.java, I found it has no Javadoc. I would like to contribute by adding “checks if a class is a valid java class name. @param class name to check ". Can you check if this is correct?

129124 commented 4 years ago

Hi, I also want to contribute the javadoc "compare two {@code int} values. @param sintA the first byte array @param sintB the second bit index @return a negative integer, zero, or a postive integer" to the function "public static int sCompare(int sintA, int sintB)" in third-party/aosp-dexutils/src/main/java/com/tencent/tinker/android/dex/util/CompareUtils.java. Can you please also check if this is correct? Thanks.