search

TencentARC / PhotoMaker

PhotoMaker [CVPR 2024]
https://photo-maker.github.io/
Other
9.39k stars 749 forks source link

Allow user to select output image aspect ratio #120

Closed DiscoNova closed 8 months ago

DiscoNova commented 8 months ago

Create a list of commonly used aspect ratios and allow the user to select one of them; use selected value as width/height of output generator. Old "Instagram 1:1" shall remain the default.

TODO: Check if the default prompt needs to be modified (including "instagram etc." eats precious tokens)

Problem: I am currently unable to test this change locally due to weird error stating "input types 'tensor' and 'tensor' are not broadcast compatible" ... before rebasing, I had no issues - now I just can't seem to get rid of this one :-/

Extra: fixed a typo in an old comment :D

Paper99 commented 8 months ago

Thanks for your great work! We've merged your PR. Could you provide more impressive examples in our README file? The quality of the current version seems to have dropped a bit, maybe try the photography template.

Paper99 commented 8 months ago

The investigation of the output aspect seems more suitable to be placed in the discussion. I have created a new discussion in https://github.com/TencentARC/PhotoMaker/discussions/121.

DiscoNova commented 8 months ago

Regarding my testing problem ... I was apparently just running a wrong version of numpy in my environment :-p