TencentQQGYLab / ComfyUI-ELLA

ELLA nodes for ComfyUI
298 stars 13 forks source link

Using the new "Concat" node to combine totally empty "T5 Text Encode" with normal "Clip Text Encode" gives WAY better results than actually using "T5 Text Encode", Lora or no Lora #24

Open Akira13641 opened 2 months ago

Akira13641 commented 2 months ago

This setup: image

created this image: image

This setup: image

created this image: image

Akira13641 commented 2 months ago

So it seems like whatever concatting with empty "Clip Text Encode" does should just actually be what "T5 Text Encode" does internally by default, all the time, otherwise "T5 Text Encode" is worse no matter what

JettHu commented 2 months ago

ELLA is for comprehending dense prompts, encompassing multiple objects, detailed attributes, complex relationships, long-text alignment, etc. However, there is no guarantee that ELLA will bring better results in aesthetic scores.

whatever concatting with empty "Clip Text Encode" does should just actually be what "T5 Text Encode" does internally by default

The current design is to be more flexible usage. Thanks for the suggestion, I will consider adding a text encode, using both t5 and clip by default. But before doing this, t5 weighted prompt support need to be solved first (The prompt we give to clip will always have a weight).

JettHu commented 2 months ago

@Akira13641 I've add a ELLA Text Encode node to automatically concat ella and clip condition.