TencentQQGYLab / ComfyUI-ELLA

ELLA nodes for ComfyUI
347 stars 18 forks source link

AYS + Ella = anyone else getting superdark image generations? #39

Closed Duemellon closed 6 months ago

Duemellon commented 7 months ago

When I combine the the images came out dark, like barely discernible using EpicRealism 1.5 & some other models. Is this a thing for other people too?

Duemellon commented 7 months ago

I think it's the default step count for AYS that was 10. Changed it 20 & it makes it better.

Duemellon commented 7 months ago

still darker than usual even with more steps.

JettHu commented 7 months ago

I think AYS steps and denoise should be the same as Set ELLA Timesteps node. Do you mind share your workflow?

Duemellon commented 6 months ago

15 step, euler ComfyUI_04940_

20 step euler ComfyUI_04949_

30 step euler ComfyUI_04955_

20 step dpmpp ComfyUI_04956_

30 step dpmpp ComfyUI_04961_

20 step euler ComfyUI_04971_

30 step dpmpp ComfyUI_04967_

Maybe it's the model? I tried other models & they trend this way too. No one else seems to be having this complaint so it's probably just something I'm doing.

ELLA-AYS.json

JettHu commented 6 months ago

I noticed that add_noise is turned off in your workflow.

image

You can try turning it on.

steps add_noise on add_noise off
20 image image
10 image image

However, I did find that the quality of the generated images will be higher when the steps are larger.

JettHu commented 6 months ago

I think AYS steps and denoise should be the same as Set ELLA Timesteps node. Do you mind share your workflow?

Sorry, what I said before is wrong. Once the sigmas is given to Set ELLA Timesteps node, it's other parameters (scheduler, steps, and denoise) will not take effect.

JettHu commented 6 months ago

In addition, it may be necessary to lower the cfg

The results in the paper used DPM-Solver++(2M) with 10 steps, so I used the same parameters to generate more images:

KSamplerSelect sampler_name: dpmpp_2m; AlignYourStepsScheduler model_type: SD1, steps: 10, denoise: 1.0

all result with same noise_seed

cfg 3 4 5 6 7 8
image image image image image image
Duemellon commented 6 months ago

add noise, CFG, & step count helped