Flatpak locale not working/load (French)

RobOT05442309 commented 2 years ago

Hello,

First of all, thanks for your work on this amazing app!

I saw that you've made GUI translation available for several languages including French, but after installing and setup the app, I still have english language display on button into the GUI, I've digging a bit before posting an issue but so far I'm out of luck to get things work.

System: Fedora 36
Flatpak version: 1.12.7
System language : French

Installation (system)

Command used for install:

> flatpak install flathub com.github.tenderowl.frog

I have also forced the installation of locale (even if they where still installed by default)

> flatpak install flathub com.github.tenderowl.frog.Locale

Try a flatpak update after install (in case something missing)

> flatpak update

Configuration (system)

This is some output of my system configuration:

> flatpak config --system --list

languages: fr;en (default: fr)
extra-languages: *unset*

> flatpak config --user --list

languages: fr;en (default: fr)
extra-languages: *unset*

Informations (flatpak)

> flatpak info com.github.tenderowl.frog

Frog - Extract text from anywhere, even QR code

ID: com.github.tenderowl.frog
Ref: app/com.github.tenderowl.frog/x86_64/stable
Arch: x86_64
Branch: stable
Version: 1.1.1
License: MIT
Origin: flathub
Collection: org.flathub.Stable
Installation: system
Installed: 26,4 MB
Runtime: org.gnome.Platform/x86_64/42
Sdk: org.gnome.Sdk/x86_64/42

Commit: b14bfaf3fcdb7dd3d6e9f4aacff5d0e459ef30498f661edc8a354f77b511d726
Parent: 33449479830dd70e38cdbbf257aba67bb3511cf838aebac7cf0f1f41cabacea6
Subject: Update to 1.1.2 (9910ebcd)
Date: 2022-06-07 10:51:01 +0000

> flatpak info com.github.tenderowl.frog.Locale

ID: com.github.tenderowl.frog.Locale
Ref: runtime/com.github.tenderowl.frog.Locale/x86_64/stable
Arch: x86_64
Branch: stable
Origin: flathub
Collection: org.flathub.Stable
Installation: system
Installed: 512 bytes

Commit: dac13a117167ba47667cf6e6a0f8f8c7127b2112cfcfd0ea3068879aeb85cb94
Parent: 23eea8c74d1ed72b4d1b3d1cfd9677896cd11616601b97075d16b29cf1ce5de7
Subject: Update to 1.1.2 (9910ebcd)
Date: 2022-06-07 10:51:06 +0000
Subdirectories: /en,/fr

Locales (testing)

So far I've try to dig a bit and it seems that translation file are not present in the flatpak build (I don't know if this is relevant):

> flatpak run --command=ls com.github.tenderowl.frog /app/share/locale/

ja  ru

> ls -la /var/lib/flatpak/app/com.github.tenderowl.frog/current/active/files/share/locale/

total 8
drwxr-xr-x.  2 root root 4096  1 janv.  1970 .
drwxr-xr-x. 13 root root 4096  1 janv.  1970 ..
lrwxrwxrwx.  1 root root   38  9 juin  11:37 ja -> ../../share/runtime/locale/ja/share/ja
lrwxrwxrwx.  1 root root   38  9 juin  11:37 ru -> ../../share/runtime/locale/ru/share/ru

> ls -la /var/lib/flatpak/app/com.github.tenderowl.frog/current/active/files/share/runtime/locale/

total 16
drwxr-xr-x. 4 root root 4096  1 janv.  1970 .
drwxr-xr-x. 3 root root 4096  1 janv.  1970 ..
drwxr-xr-x. 2 root root 4096  1 janv.  1970 ja
drwxr-xr-x. 2 root root 4096  1 janv.  1970 ru

Even running the application and forcing environment doesn't to work to get French language:

> flatpak run --env=LC_MESSAGES=fr_FR.UTF-8 com.github.tenderowl.frog

Links

I've find some links related to that kind of issue, one that might be relevant is:

https://github.com/flathub/org.gnome.Rhythmbox3/issues/53

I'm missing some knowledge about how flatpak might interact between runtime and app but I don't understand why it's not working at all for me to get French language in GUI.

Other flatpak app are working with French language so I think it might be related to how Frog handle things, I don't know if anyone have the same issue for other language, I haven't found any issue related on this repository (open or closed).

Thanks for your feedback on this matter when you'll get time, have a nice day.

amka commented 2 years ago

Thank you @RobOT05442309! I'll check and come back in a few days.

flipflop97 commented 2 years ago

The same happens with Dutch, the app just displays in English. So it's probably a general localisation issue.

amka commented 2 years ago

Ah, I found the issue. We're gonna need to update translation files and it will work again.

RobOT05442309 commented 2 years ago

Nice! Thanks you for the feedback and the quick resolution!

amka commented 2 years ago

@RobOT05442309 @flipflop97 please check against version 1.1.3

RobOT05442309 commented 2 years ago

Sill the same with version 1.1.3, every command listed on the report get the exact sames result, only "ru" and "ja" are available, do you need us to do something else to give you a feedback on this ?

Thanks to take time to investigate!

flipflop97 commented 2 years ago

Ah, I think I see why 😅

amka commented 2 years ago

Oh, dear. I was sure weblate will update this. Thank you @flipflop97!

RobOT05442309 commented 2 years ago

Just to give a feedback on the issue about French language, it seems to be fixed (version 1.2.0), but there is some strings that seems missing on translation on current version, I've look around the weblate translation and didn't find those strings:

When opening Frog the "catch phrase": "Extract text from anywhere"
On the second button still: "Open Image"

If the "catch phrase" is not meant to be translated, that's perfectly ok for me, but the button one is more annoying since I almost thought that translations was still broken when I open the software (that's one of the first thing I see when opening it).

Except this, that's all good for me, nice job and thanks for your time!

TenderOwl / Frog