search

Tenderly / hardhat-tenderly

Tenderly plugin for HardHat
https://www.npmjs.com/package/@tenderly/hardhat-tenderly
Other
154 stars 40 forks source link

Move hardhat from dep to devDep #133

Closed fvictorio closed 1 year ago

fvictorio commented 1 year ago

Hi, this repo has two peer dependencies (hardhat and tenderly) that are also plain dependencies. This is usually an error and can be problematic. For example, @pcaversaccio's template repo now gets an error if you try to upgrade an unrelated package (hardhat-ethers) because of that.

This PR fixes the problem by moving Hardhat to devDependencies, and by removing tenderly as a peer dependency (so it's only a plain dependency now). Hardhat as a peer + dev dependency is the common pattern for plugins. As for the tenderly package, it could also be a peer + dev dependency if you want people to be able to upgrade it independently, but I think for this particular plugin it might not be necessary. I could be wrong here though, let me know.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 2f70305fd84b5ebbd3851392850b000608114334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pcaversaccio commented 1 year ago

Can we get this resolved please, it's a really annoying bug that prevents me to upgrade hardhat-ethers. @veljko-matic @dule-git

dule-git commented 1 year ago

Hey, thanks for contributing! Sorry it took us so long! Closing this issue since we resolved it in this PR.

pcaversaccio commented 1 year ago

@dule-git thx - can confirm that fixed my issue.