search

Tenderly / tenderly-sdk

With the Tenderly SDK, you can simulate individual transactions or bundles of transactions, manage contracts and wallets, and verify contracts from your code.
https://docs.tenderly.co/tenderly-sdk
MIT License
41 stars 12 forks source link

DEVX-1040 Enable typescript strict mode #93

Closed pajcho closed 1 year ago

pajcho commented 1 year ago

This PR introduces a strict typescript mode and fixes all type issues. Alongside with that it introduces some improvements to our linting process, fixes some typos and some general improvements.

⚠️ Since the strict types are kind of a breaking change, this will require a minor release version bump.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3172c3755b44eab9d88a10735931223121ce9d5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @tenderly/sdk | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

IgorPetkovic commented 1 year ago

⚠️ Since the strict types are kind of a breaking change, this will require a minor release version bump.

Can you elaborate a bit on "kind of a breaking change"? If this will require changes by existing users, i.e. their current setup will break, it needs to be a major version bump in that case. See https://semver.org/#summary

maleksandar commented 1 year ago

⚠️ Since the strict types are kind of a breaking change, this will require a minor release version bump.

Can you elaborate a bit on "kind of a breaking change"? If this will require changes by existing users, i.e. their current setup will break, it needs to be a major version bump in that case. See https://semver.org/#summary

@IgorPetkovic minor is fine, in this case, I would say, since interfaces didn't really change. Only some of the types were expanded to explicitly include undefined | OrignalType. Therefore, for the people that are already using SDK, we are not removing anything, just adding more clarity.