Tenderly / tenderly-sdk

With the Tenderly SDK, you can simulate individual transactions or bundles of transactions, manage contracts and wallets, and verify contracts from your code.
https://docs.tenderly.co/tenderly-sdk
MIT License
41 stars 12 forks source link

TransactionParameters type does not have `save` or `save_if_fails` #98

Open marcusmolchany opened 1 year ago

marcusmolchany commented 1 year ago

We're trying to use the SDK to simulate a transaction bundle and save the results to the dashboard, and it appears that the save and save_if_fails options are not available in the SDK.

TransactionParameters types where I would expect save and save_if_fails: https://github.com/Tenderly/tenderly-sdk/blob/master/lib/executors/Simulator.types.ts#L3-L13

Where I would expect save and save_if_fails for tx simulation bundles: https://github.com/Tenderly/tenderly-sdk/blob/master/lib/executors/Simulator.ts#L128-L138

Where I would expect save and save_if_fails for an individual tx simulation: https://github.com/Tenderly/tenderly-sdk/blob/master/lib/executors/Simulator.ts#L153-L163

We're happy to make this change if these are the right places to update.

marcusmolchany commented 1 year ago

API Docs for save and save_if_fails https://docs.tenderly.co/simulations-and-forks/simulation-api/advanced-simulation-api-usage