Load_all function required job_id in job json which is created by API

Tendrl / api

Tendrl API

GNU Lesser General Public License v2.1

16 stars 16 forks source link

Load_all function required job_id in job json which is created by API #434

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

tendrl-bug-id: Tendrl/api#433 bugzilla: 1592487

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

@shtripat @shirshendu @nthomas-redhat @r0h4n please review

GowthamShanmugam commented 6 years ago

I saw Travis result, all green

shtripat commented 6 years ago

LGTM. Approved

shirshendu commented 6 years ago

@shtripat I can't merge this until you mark the review as approved on github: https://help.github.com/articles/approving-a-pull-request-with-required-reviews/

shirshendu commented 6 years ago

@GowthamShanmugam Commits need to be signed. https://help.github.com/articles/signing-commits-using-gpg/ https://help.github.com/articles/about-gpg/

You'll need to amend this commit with a signature, and force push to your branch. (Github will need this PR to be approved again once a signed commit is pushed @shtripat)