Tendrl / commons

Common code usable by all Tendrl components
http://www.tendrl.org
GNU Lesser General Public License v2.1
4 stars 23 forks source link

Raising node down alert only for managed nodes #1003

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

tendrl-bug-id: Tendrl/commons#1002 bugzilla: 1580385

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

Handled a corner case here, all nodes are down and some nodes are ready to expand then current logic won't consider all nodes are down and it won't raise a brick alert. Here I modified logic like all managed nodes are down and any unmanaged node status is up, in this case also I am raising all brick are down and volume down.

if i am not checked unmanaged node then if we stop and down the unmanaged nodes before cluster import also node down alert will be raised.

GowthamShanmugam commented 6 years ago

verified

GowthamShanmugam commented 6 years ago

@r0h4n @shtripat @nthomas-redhat please review

GowthamShanmugam commented 6 years ago

I verified @shtripat but I this is a very corner case so it not strike in my mind at last build.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6b0ded2). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1003   +/-   ##
=========================================
  Coverage          ?   64.86%           
=========================================
  Files             ?       90           
  Lines             ?     3626           
  Branches          ?      455           
=========================================
  Hits              ?     2352           
  Misses            ?     1213           
  Partials          ?       61
Impacted Files Coverage Δ
tendrl/commons/objects/node_context/__init__.py 40.97% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b0ded2...601336d. Read the comment docs.