search

Tendrl / commons

Common code usable by all Tendrl components
http://www.tendrl.org
GNU Lesser General Public License v2.1
4 stars 23 forks source link

Fixing an issue of geo-replication count not shown in grafana #1042

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

tendrl-bug-id: Tendrl/commons#1041 bugzilla: 1603175

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

@shtripat @r0h4n @nthomas-redhat please review

GowthamShanmugam commented 6 years ago

Verified with geo-replicaion-session

GowthamShanmugam commented 6 years ago

It has to be in any one place, but I can't remove this now. because i don't know what are all the places it is referred

shtripat commented 6 years ago

LGTM

codecov[bot] commented 6 years ago

Codecov Report

Merging #1042 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   82.79%   82.79%   +<.01%     
==========================================
  Files          90       90              
  Lines        3708     3709       +1     
  Branches      477      477              
==========================================
+ Hits         3070     3071       +1     
  Misses        542      542              
  Partials       96       96
Impacted Files Coverage Δ
...ommons/objects/geo_replication_session/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef73cc9...de1c96d. Read the comment docs.

GowthamShanmugam commented 6 years ago

@nthomas-redhat changes done

nthomas-redhat commented 6 years ago

@GowthamShanmugam , centos build failed(Timed out), pls resubmit