Tendrl / commons

Common code usable by all Tendrl components

http://www.tendrl.org

GNU Lesser General Public License v2.1

4 stars 23 forks source link

Added job for profiling after import #1061

Closed anmolsachan closed 5 years ago

anmolsachan commented 5 years ago

tendrl-bug-id: Tendrl/commons#1062 bugzilla: 1638314 Signed-off-by: Anmol Sachan anmol13694@gmail.com

anmolsachan commented 5 years ago

@shtripat @nthomas-redhat @GowthamShanmugam Please review.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a7c9d86). Click here to learn what that means. The diff coverage is 30%.

@@            Coverage Diff            @@
##             master    #1061   +/-   ##
=========================================
  Coverage          ?   82.23%           
=========================================
  Files             ?       90           
  Lines             ?     3727           
  Branches          ?      480           
=========================================
  Hits              ?     3065           
  Misses            ?      563           
  Partials          ?       99

Impacted Files	Coverage Δ
tendrl/commons/flows/import_cluster/__init__.py	`67.94% <30%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7c9d86...7fb8301. Read the comment docs.

GowthamShanmugam commented 5 years ago

Profiling enabling logic is blocking cluster-integration sync, It will take huge time for the cluster which has a large number of volumes. So by this time volumes details may be deleted by TTL.

@shtripat @cloudbehl we need some logic to handle this here, otherwise no use of reducing import time.

GowthamShanmugam commented 5 years ago

Profiling enabling logic is blocking cluster-integration sync, It will take huge time for the cluster which has a large number of volumes. So by this time volumes details may be deleted by TTL.

@shtripat @cloudbehl we need some logic to handle this here, otherwise no use of reducing import time.

GowthamShanmugam commented 5 years ago

Profiling enabling logic is blocking cluster-integration sync, It will take huge time for the cluster which has a large number of volumes. So by this time volumes details may be deleted by TTL.

@shtripat @cloudbehl we need some logic to handle this here, otherwise no use of reducing import time.

GowthamShanmugam commented 5 years ago

Profiling enabling logic is blocking cluster-integration sync, It will take huge time for the cluster which has a large number of volumes. So by this time volumes details may be deleted by TTL.

@shtripat @cloudbehl we need some logic to handle this here, otherwise no use of reducing import time.

GowthamShanmugam commented 5 years ago

Profiling enabling logic is blocking cluster-integration sync, It will take huge time for the cluster which has a large number of volumes. So by this time volumes details may be deleted by TTL.

@shtripat @cloudbehl we need some logic to handle this here, otherwise no use of reducing import time.

GowthamShanmugam commented 5 years ago

Profiling enabling logic is blocking cluster-integration sync, It will take huge time for the cluster which has a large number of volumes. So by this time volumes details may be deleted by TTL.

@shtripat @cloudbehl we need some logic to handle this here, otherwise no use of reducing import time.

anmolsachan commented 5 years ago

Closing this as a better way was found. Decided to keep profiling in the beginning of the import, within the flow.