anmolsachan commented 5 years ago

tendrl-bug-id: Tendrl/commons/issues/1065 bugzilla: 1655420 Signed-off-by: Anmol Sachan anmol13694@gmail.com

anmolsachan commented 5 years ago

@shirshendu Yes we need a PR there

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@07677cf). Click here to learn what that means. The diff coverage is 8.88%.

@@            Coverage Diff            @@
##             master    #1064   +/-   ##
=========================================
  Coverage          ?   81.51%           
=========================================
  Files             ?       90           
  Lines             ?     3754           
  Branches          ?      487           
=========================================
  Hits              ?     3060           
  Misses            ?      596           
  Partials          ?       98

Impacted Files	Coverage Δ
...endrl/commons/flows/import_cluster/gluster_help.py	`59.61% <8.82%> (ø)`
...s/objects/cluster/atoms/import_cluster/__init__.py	`11.2% <9.09%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07677cf...615452d. Read the comment docs.

shtripat commented 5 years ago

Fix the commit message and pep8 issues.

shtripat commented 5 years ago

@anmolsachan Fix the build issues including pep8. Still failing.

anmolsachan commented 5 years ago

@shtripat This PR does not need any change w.r.t pep8. I have verified locally. This can be merged

GowthamShanmugam commented 5 years ago

Need to merge this, otherwise, upstream profile enable won't happen part of import flow.

Tendrl / commons

Moved profiling to the begining of import flow #1064

Codecov Report