Tendrl / commons

Common code usable by all Tendrl components
http://www.tendrl.org
GNU Lesser General Public License v2.1
4 stars 23 forks source link

Updated tendrl-commons spec with minimal ansible version it requires #1068

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

bugzilla: 1654338 tendrl-bug-id: Tendrl/commons#1067

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 5 years ago

@nthomas-redhat @shtripat @TimothyAsir please review

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a7c9d86). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1068   +/-   ##
=========================================
  Coverage          ?   82.37%           
=========================================
  Files             ?       90           
  Lines             ?     3717           
  Branches          ?      478           
=========================================
  Hits              ?     3062           
  Misses            ?      556           
  Partials          ?       99

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7c9d86...b683b39. Read the comment docs.

shtripat commented 5 years ago

Isnt it duplicate of https://github.com/Tendrl/commons/pull/1055 ?

GowthamShanmugam commented 5 years ago

@shtripat yes, i am not noticed that PR :), i am closing this PR