search

Tendrl / commons

Common code usable by all Tendrl components
http://www.tendrl.org
GNU Lesser General Public License v2.1
4 stars 23 forks source link

Incorrect number of hosts down reported #1077

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

tendrl-bug-id: Tendrl/commons#1076 bugzilla: 1687333

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 5 years ago

@fbalak @shtripat please review

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2e7d7f4). Click here to learn what that means. The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1077   +/-   ##
=========================================
  Coverage          ?   80.87%           
=========================================
  Files             ?       91           
  Lines             ?     3816           
  Branches          ?      500           
=========================================
  Hits              ?     3086           
  Misses            ?      628           
  Partials          ?      102
Impacted Files Coverage Δ
tendrl/commons/utils/central_store/utils.py 61.9% <33.33%> (ø)
tendrl/commons/objects/node_context/__init__.py 85.51% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e7d7f4...ded9a04. Read the comment docs.

GowthamShanmugam commented 5 years ago

@shtripat @nthomas-redhat please review

GowthamShanmugam commented 5 years ago

@shtripat changes done, please review