Closed GowthamShanmugam closed 5 years ago
@shtripat @nthomas-redhat please review
Merging #1079 into master will decrease coverage by
0.94%
. The diff coverage is35.89%
.
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
- Coverage 80.81% 79.86% -0.95%
==========================================
Files 91 92 +1
Lines 3826 3894 +68
Branches 502 515 +13
==========================================
+ Hits 3092 3110 +18
- Misses 631 677 +46
- Partials 103 107 +4
Impacted Files | Coverage Δ | |
---|---|---|
tendrl/commons/flows/unmanage_cluster/__init__.py | 86.36% <ø> (ø) |
:arrow_up: |
...mmons/objects/node/flows/stop_services/__init__.py | 75.86% <ø> (ø) |
:arrow_up: |
...ts/cluster/atoms/set_cluster_unmanaged/__init__.py | 100% <100%> (ø) |
:arrow_up: |
tendrl/commons/objects/cluster/__init__.py | 100% <100%> (ø) |
:arrow_up: |
...r_peer/atoms/gluster_server_peer_check/__init__.py | 27.27% <27.27%> (ø) |
|
...s/cluster/atoms/delete_cluster_details/__init__.py | 76.19% <42.85%> (-9.53%) |
:arrow_down: |
...luster/atoms/stop_integration_services/__init__.py | 77.04% <44.44%> (-6.88%) |
:arrow_down: |
...cluster/atoms/stop_monitoring_services/__init__.py | 77.04% <44.44%> (-6.88%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 71d5727...15d6d7f. Read the comment docs.
@shtripat please review
@shtripat changes are done
bugzilla: 1645221 tendrl-bug-id: Tendrl/commons#1078
Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com