search

Tendrl / commons

Common code usable by all Tendrl components
http://www.tendrl.org
GNU Lesser General Public License v2.1
4 stars 23 forks source link

Fixed issue: Incorrect number of hosts down reported #1087

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

bugzilla: 1687333 tendrl-bug-id: Tendrl/commons#1076

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 5 years ago

@shtripat please review

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e6f20cd). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1087   +/-   ##
========================================
  Coverage          ?   0.02%           
========================================
  Files             ?      92           
  Lines             ?    3893           
  Branches          ?     516           
========================================
  Hits              ?       1           
  Misses            ?    3892           
  Partials          ?       0
Impacted Files Coverage Δ
tendrl/commons/objects/__init__.py 0% <0%> (ø)
tendrl/commons/objects/node_context/__init__.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6f20cd...497c5be. Read the comment docs.

GowthamShanmugam commented 5 years ago

There is some problem with fixing testcase issue for tendrl-commons, for now, we will go ahead and merge this PR and i will create an upstream issue for the test case fix.

GowthamShanmugam commented 5 years ago

@shtripat Please review and merge this patch

GowthamShanmugam commented 5 years ago

@shtripat verified