search

Tendrl / gluster-integration

Extracts all data from a Gluster cluster for consumption by Tendrl
GNU Lesser General Public License v2.1
6 stars 20 forks source link

Changed default volume deleted flag from False to None #582

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

tendrl-bug-id: Tendrl/gluster-integration#575

Signed-off-by: GowthamShanmugam gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

If volume is deleted flag is marked as True then it won't be changed because we are not pushing None value in etcd

codecov[bot] commented 6 years ago

Codecov Report

Merging #582 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          70       70           
  Lines        2571     2571           
  Branches      362      362           
=======================================
  Hits         1078     1078           
  Misses       1461     1461           
  Partials       32       32
Impacted Files Coverage Δ
...drl/gluster_integration/objects/volume/__init__.py 94.87% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b04c49e...30ead04. Read the comment docs.

GowthamShanmugam commented 6 years ago

Tendrl/monitoring-integration#354

GowthamShanmugam commented 6 years ago

@shtripat @nthomas-redhat @r0h4n please review

GowthamShanmugam commented 6 years ago

@shtripat @r0h4n @nthomas-redhat please review

r0h4n commented 6 years ago

@GowthamShanmugam I am not sure why you are talking about "volume_alert_counter" in this PR

Also, the commits need to be signed. Please ensure that in future

GowthamShanmugam commented 6 years ago

ah, sorry i wrongly commented here :)