search

Tendrl / gluster-integration

Extracts all data from a Gluster cluster for consumption by Tendrl
GNU Lesser General Public License v2.1
6 stars 20 forks source link

Creating native message handler object after integration_id found #664

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

Inside message handler constructor we are finding cluster_name using integration_id, if it before called integration_id found then it will raise alert with None

tendrl-bug-id: Tendrl/gluster-integration#662 bugzilla: 1588440

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

https://github.com/Tendrl/gluster-integration/blob/master/tendrl/gluster_integration/message/callback.py#L35

GowthamShanmugam commented 6 years ago

@shtripat @r0h4n please review

codecov[bot] commented 6 years ago

Codecov Report

Merging #664 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   38.76%   38.76%           
=======================================
  Files          42       42           
  Lines        2056     2056           
  Branches      279      279           
=======================================
  Hits          797      797           
  Misses       1232     1232           
  Partials       27       27
Impacted Files Coverage Δ
tendrl/gluster_integration/manager/__init__.py 50.76% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78cbb58...ba66e17. Read the comment docs.