Tendrl / gluster-integration

Extracts all data from a Gluster cluster for consumption by Tendrl
GNU Lesser General Public License v2.1
6 stars 20 forks source link

Volume alert raised with volume name None #668

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

It is one more corner case problem, the problem is we down all storage nodes and after volume are deleted by TTL then we are starting all the nodes, what is happening all storage nodes are pushing volume_rebalance data into etcd before we decide provisioner. now volume entry present with rebalance directory but there are no details about volume because volume details are populated by provisioner only. but provisioner is decided in-between of execution then global details are executed before volume details populate. so alert raised with name None.

tendrl-bug-id: Tendrl/gluster-integration#667 bugzilla: 1595295

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #668 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   38.48%   38.48%           
=======================================
  Files          42       42           
  Lines        2063     2063           
  Branches      280      280           
=======================================
  Hits          794      794           
  Misses       1242     1242           
  Partials       27       27
Impacted Files Coverage Δ
tendrl/gluster_integration/sds_sync/__init__.py 13.82% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 999d3e3...25898ee. Read the comment docs.

GowthamShanmugam commented 6 years ago

@shtripat @r0h4n @nthomas-redhat please review

nthomas-redhat commented 6 years ago

@GowthamShanmugam , Can we also make sure to not pouplate global details and re-bablace data if the volume details are not populated?

nthomas-redhat commented 6 years ago

@GowthamShanmugam , resolve the merge conflicts