shtripat commented 6 years ago

There seems to be some meory leaks in gfapi and due to that if we make in-memory calls to gfapi, the memory utilization on the nodes keeps increasing slowly. If we make subprocess call this increase would be eventual and no overall increase happens to the memory utilization of the node.

tendrl-bug-id: Tendrl/gluster-integration#681 bugzilla: 1599987 Signed-off-by: Shubhendu shtripat@redhat.com

GowthamShanmugam commented 6 years ago

this will solve issue: 1599985 also

GowthamShanmugam commented 6 years ago

LGTM

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@502ec58). Click here to learn what that means. The diff coverage is 47.27%.

@@            Coverage Diff            @@
##             master     #680   +/-   ##
=========================================
  Coverage          ?   38.67%           
=========================================
  Files             ?       42           
  Lines             ?     2092           
  Branches          ?      284           
=========================================
  Hits              ?      809           
  Misses            ?     1257           
  Partials          ?       26

Impacted Files	Coverage Δ
tendrl/gluster_integration/sds_sync/__init__.py	`13.69% <0%> (ø)`
...rl/gluster_integration/sds_sync/vol_utilization.py	`0% <0%> (ø)`
tendrl/gluster_integration/sds_sync/utilization.py	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 502ec58...03e0842. Read the comment docs.

Tendrl / gluster-integration

Invoke volume utilization calculation as subprocess #680

Codecov Report