GowthamShanmugam commented 6 years ago

bugzilla: 1637977 tendrl-bug-id: Tendrl/gluster-integration#703

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

@shtripat @anmolsachan @nthomas-redhat @cloudbehl please review

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@88a94a5). Click here to learn what that means. The diff coverage is 7.93%.

@@            Coverage Diff            @@
##             master     #704   +/-   ##
=========================================
  Coverage          ?   38.78%           
=========================================
  Files             ?       42           
  Lines             ?     2104           
  Branches          ?      286           
=========================================
  Hits              ?      816           
  Misses            ?     1258           
  Partials          ?       30

Impacted Files	Coverage Δ
...uster_integration/sds_sync/brick_device_details.py	`17.39% <0%> (ø)`
tendrl/gluster_integration/sds_sync/__init__.py	`13.58% <5.88%> (ø)`
.../gluster_integration/sds_sync/brick_utilization.py	`11.39% <66.66%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88a94a5...726ba46. Read the comment docs.

GowthamShanmugam commented 6 years ago

This PR needs: Tendrl/api/pull/451

GowthamShanmugam commented 6 years ago

@shtripat changes done

shtripat commented 6 years ago

Looks fine now. But make sure there are no regressions due to these changes.

shtripat commented 5 years ago

Check and fix build issues.

shtripat commented 5 years ago

@GowthamShanmugam please rebase and fix the coverage issue.

shtripat commented 5 years ago

LGTM. Please rebase

Tendrl / gluster-integration

Removing python-blivet dependency #704

Codecov Report