search

Tendrl / gluster-integration

Extracts all data from a Gluster cluster for consumption by Tendrl
GNU Lesser General Public License v2.1
6 stars 20 forks source link

Fixed Volume Utilization calculation for other volumes #706

Closed umangachapagain closed 5 years ago

umangachapagain commented 6 years ago

Fixed Volume Utilization calculation for other volumes when all the bricks in one of the volumes are down.

Bugzilla-id : 1641413 tendrl-bug-id: Tendrl/gluster-integration#705

Signed-off-by: Umanga Chapagain chapagainumanga@gmail.com

umangachapagain commented 6 years ago

@shtripat @GowthamShanmugam Please review.

centos-ci commented 6 years ago

Can one of the admins verify this patch?

centos-ci commented 6 years ago

Can one of the admins verify this patch?

codecov[bot] commented 6 years ago

Codecov Report

Merging #706 into master will decrease coverage by 0.19%. The diff coverage is 40.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #706     +/-   ##
=========================================
- Coverage   38.67%   38.47%   -0.2%     
=========================================
  Files          42       42             
  Lines        2092     2105     +13     
  Branches      282      288      +6     
=========================================
+ Hits          809      810      +1     
- Misses       1257     1265      +8     
- Partials       26       30      +4
Impacted Files Coverage Δ
...l/gluster_integration/sds_sync/rebalance_status.py 6.66% <ø> (ø) :arrow_up:
...drl/gluster_integration/sds_sync/georep_details.py 9.33% <ø> (ø) :arrow_up:
tendrl/gluster_integration/sds_sync/__init__.py 13.62% <0%> (ø) :arrow_up:
...rl/gluster_integration/sds_sync/vol_utilization.py 0% <0%> (ø) :arrow_up:
...ter_integration/objects/global_details/__init__.py 27.27% <0%> (ø) :arrow_up:
tendrl/gluster_integration/sds_sync/utilization.py 82.6% <61.9%> (-17.4%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46b3f25...d23b2dd. Read the comment docs.

shtripat commented 6 years ago

Fix the issue at https://travis-ci.org/Tendrl/gluster-integration/jobs/444762365. Otherwise looks fine.

GowthamShanmugam commented 6 years ago

give tendrl-bug-id like Tendrl/gluster-integration#705

GowthamShanmugam commented 6 years ago

LGTM

umangachapagain commented 6 years ago

@GowthamShanmugam @shtripat Please review the new changes related to Error Parsing.

umangachapagain commented 5 years ago

@shtripat @GowthamShanmugam @anmolsachan

anmolsachan commented 5 years ago

Resolve Codacy, pep8 issues. Also fix related test cases. Add test cases in a separate commit. Also it would be better to squash your code changes into one single commit.

anmolsachan commented 5 years ago

Looks good, one minor comment and Still seeing pep8 issues.

GowthamShanmugam commented 5 years ago

LGTM

anmolsachan commented 5 years ago

LGTM