search

Tendrl / monitoring-integration

Component that enables integration with external monitoring services.
GNU Lesser General Public License v2.1
4 stars 13 forks source link

Removed Weeks Remaining and growth rate panels from Host dashboard and cluster dashboard #565

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

bugzilla: 1614005 tendrl-bug-id: Tendrl/monitoring-integration#564

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #565 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files          40       40           
  Lines        2300     2300           
  Branches      345      345           
=======================================
  Hits         1037     1037           
  Misses       1210     1210           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c46ae97...33cc192. Read the comment docs.

GowthamShanmugam commented 6 years ago

Cluster dashboard:

after_remove_cluster_dash

host dashboard: after remove in host db

@cloudbehl @julienlim @mbukatov

shtripat commented 6 years ago

Looks good as per https://bugzilla.redhat.com/show_bug.cgi?id=1614005#c9

cloudbehl commented 6 years ago

@julienlim can you review this patch. After stretching the panels the graphs were looking too big.

So we reduced the width of some panels and made it into two rows.

@GowthamShanmugam can you attach the original screenshots. So @julienlim can see the difference.

GowthamShanmugam commented 6 years ago

Cluster_dashboard:

before_remove_in_cluster

Host Dashboard: before_remove_in_host

Before removing weekly remaining and weekly growth rate panels

GowthamShanmugam commented 6 years ago

@cloudbehl i have added both

nthomas-redhat commented 6 years ago

Looks good

julienlim commented 6 years ago

Reviewed https://github.com/Tendrl/monitoring-integration/pull/565#issuecomment-420219197 and looks fine to me.

@GowthamShanmugam @nthomas-redhat @cloudbehl

cloudbehl commented 6 years ago

@julienlim Thanks!

@GowthamShanmugam is this patch verified?