Tendrl / monitoring-integration

Component that enables integration with external monitoring services.

GNU Lesser General Public License v2.1

4 stars 13 forks source link

Removing and recreating graphiteDB while upgrading tendrl #590

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

bugzilla: 1658245 tendrl-bug-id: Tendrl/monitoring-integration#589

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 5 years ago

@shtripat @nthomas-redhat @dahorak please review

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@694d04d). Click here to learn what that means. The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #590   +/-   ##
=========================================
  Coverage          ?   43.72%           
=========================================
  Files             ?       42           
  Lines             ?     2381           
  Branches          ?      352           
=========================================
  Hits              ?     1041           
  Misses            ?     1287           
  Partials          ?       53

Impacted Files	Coverage Δ
tendrl/monitoring_integration/upgrades/utils.py	`0% <0%> (ø)`
...nitoring_integration/upgrades/delete_dashboards.py	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 694d04d...3b903f8. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@694d04d). Click here to learn what that means. The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #590   +/-   ##
=========================================
  Coverage          ?   43.33%           
=========================================
  Files             ?       42           
  Lines             ?     2402           
  Branches          ?      356           
=========================================
  Hits              ?     1041           
  Misses            ?     1308           
  Partials          ?       53

Impacted Files	Coverage Δ
tendrl/monitoring_integration/upgrades/utils.py	`0% <0%> (ø)`
...nitoring_integration/upgrades/delete_dashboards.py	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 694d04d...ebf6c34. Read the comment docs.

GowthamShanmugam commented 5 years ago

I have created utility function and I put separate try-catch for wherever it required, now one function failure won't stop upgrade execution flow.

GowthamShanmugam commented 5 years ago

@dahorak @shtripat changes done