search

Tendrl / monitoring-integration

Component that enables integration with external monitoring services.
GNU Lesser General Public License v2.1
4 stars 13 forks source link

tendrl-monitoring-integration service fails to start with HTTPS is enabled #592

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

bugzilla: 1679060 tendrl-bug-id: Tendrl/monitoring-integration#591

GowthamShanmugam commented 5 years ago

@shtripat @dahorak @nthomas-redhat please review

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e8798f2). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #592   +/-   ##
=========================================
  Coverage          ?   43.26%           
=========================================
  Files             ?       42           
  Lines             ?     2406           
  Branches          ?      356           
=========================================
  Hits              ?     1041           
  Misses            ?     1312           
  Partials          ?       53
Impacted Files Coverage Δ
...monitoring_integration/grafana/datasource_utils.py 31.91% <ø> (ø)
tendrl/monitoring_integration/graphite/__init__.py 8.01% <0%> (ø)
.../monitoring_integration/grafana/alert_dashboard.py 60.71% <0%> (ø)
.../monitoring_integration/graphite/graphite_utils.py 69.91% <0%> (ø)
...onitoring_integration/grafana/grafana_org_utils.py 20.31% <0%> (ø)
...toring_integration/grafana/notification_channel.py 55.55% <0%> (ø)
...nitoring_integration/upgrades/delete_dashboards.py 0% <0%> (ø)
.../monitoring_integration/grafana/dashboard_utils.py 27.27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8798f2...739f359. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e8798f2). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #592   +/-   ##
=========================================
  Coverage          ?   43.26%           
=========================================
  Files             ?       42           
  Lines             ?     2406           
  Branches          ?      356           
=========================================
  Hits              ?     1041           
  Misses            ?     1312           
  Partials          ?       53
Impacted Files Coverage Δ
...monitoring_integration/grafana/datasource_utils.py 31.91% <ø> (ø)
tendrl/monitoring_integration/graphite/__init__.py 8.01% <0%> (ø)
.../monitoring_integration/grafana/alert_dashboard.py 60.71% <0%> (ø)
.../monitoring_integration/graphite/graphite_utils.py 69.91% <0%> (ø)
...onitoring_integration/grafana/grafana_org_utils.py 20.31% <0%> (ø)
...toring_integration/grafana/notification_channel.py 55.55% <0%> (ø)
...nitoring_integration/upgrades/delete_dashboards.py 0% <0%> (ø)
.../monitoring_integration/grafana/dashboard_utils.py 27.27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8798f2...739f359. Read the comment docs.

GowthamShanmugam commented 5 years ago

@shtripat changes done

shtripat commented 5 years ago

Looks good to me now. Please verify all the scenarios.

GowthamShanmugam commented 5 years ago

Verified