search

Tendrl / node-agent

A python agent local to every managed storage node in the sds cluster
GNU Lesser General Public License v2.1
4 stars 14 forks source link

After migration to graphite-1.1.4 the brick specific dashboards are not visible in grafana #865

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

tendrl-bug-id: Tendrl/node-agent#864 bugzilla: 1660779

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b5cb88e). Click here to learn what that means. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #865   +/-   ##
=========================================
  Coverage          ?   41.93%           
=========================================
  Files             ?       72           
  Lines             ?     3043           
  Branches          ?      450           
=========================================
  Hits              ?     1276           
  Misses            ?     1703           
  Partials          ?       64
Impacted Files Coverage Δ
...lectors/gluster/tendrl_gluster_brick_disk_stats.py 0% <0%> (ø)
...r/low_weight/tendrl_glusterfs_brick_utilization.py 81.77% <100%> (ø)
...ster/heavy_weight/tendrl_glusterfs_profile_info.py 80.47% <100%> (ø)
...ter/low_weight/tendrl_glusterfs_health_counters.py 83.87% <100%> (ø)
...s/gluster/heavy_weight/tendrl_gluster_heal_info.py 15.66% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5cb88e...c867cf0. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b5cb88e). Click here to learn what that means. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #865   +/-   ##
=========================================
  Coverage          ?   41.93%           
=========================================
  Files             ?       72           
  Lines             ?     3043           
  Branches          ?      450           
=========================================
  Hits              ?     1276           
  Misses            ?     1703           
  Partials          ?       64
Impacted Files Coverage Δ
tendrl/node_agent/tests/mock_gluster_state.py 100% <ø> (ø)
...lectors/gluster/tendrl_gluster_brick_disk_stats.py 0% <0%> (ø)
...r/low_weight/tendrl_glusterfs_brick_utilization.py 81.77% <100%> (ø)
...ster/heavy_weight/tendrl_glusterfs_profile_info.py 80.47% <100%> (ø)
...ter/low_weight/tendrl_glusterfs_health_counters.py 83.87% <100%> (ø)
...s/gluster/heavy_weight/tendrl_gluster_heal_info.py 15.66% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5cb88e...d5288bf. Read the comment docs.

GowthamShanmugam commented 5 years ago

@shtripat changes done

GowthamShanmugam commented 5 years ago

Tendrl/commons/pull/1071

GowthamShanmugam commented 5 years ago

@shtripat @nthomas-redhat please review and merge the patch

GowthamShanmugam commented 5 years ago

@shtripat @nthomas-redhat i have verified the changes, it works fine

GowthamShanmugam commented 5 years ago

@shtripat changes done

shtripat commented 5 years ago

Please rebase and fix the minor pep8 issues.