search

Tendrl / node-agent

A python agent local to every managed storage node in the sds cluster
GNU Lesser General Public License v2.1
4 stars 14 forks source link

Logrotate for tendrl log files #868

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

bugzilla: 1654183 tendrl-bug-id: Tendrl/node-agent#867

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 5 years ago

@dahorak @mbukatov @fbalak

GowthamShanmugam commented 5 years ago

@shtripat @nthomas-redhat @TimothyAsirJeyasing please review

GowthamShanmugam commented 5 years ago

i tested using a command: logrotate -v /etc/logrotate.d/tendrl_logrotate.conf it will fire logrotation manually for that configuration file

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@67f0be8). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #868   +/-   ##
=========================================
  Coverage          ?   41.93%           
=========================================
  Files             ?       72           
  Lines             ?     3043           
  Branches          ?      450           
=========================================
  Hits              ?     1276           
  Misses            ?     1703           
  Partials          ?       64

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67f0be8...3a1fd98. Read the comment docs.

TimothyAsirJeyasing commented 5 years ago

LGTM, Kindly test it once with local build and install

GowthamShanmugam commented 5 years ago

I created local build and verified: the command which I used is: logrotate -vf /etc/logrotate.d/tendrl_logrotate.conf