search

Tendrl / node-agent

A python agent local to every managed storage node in the sds cluster
GNU Lesser General Public License v2.1
4 stars 14 forks source link

Modified collectd logic to read node_id from etcd instead of reading from conf file #874

Closed GowthamShanmugam closed 5 years ago

GowthamShanmugam commented 5 years ago

bugzilla: 1647910 tendrl-bug-id: Tendrl/node-agent#859

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9f55946). Click here to learn what that means. The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #874   +/-   ##
=========================================
  Coverage          ?   41.89%           
=========================================
  Files             ?       72           
  Lines             ?     3046           
  Branches          ?      450           
=========================================
  Hits              ?     1276           
  Misses            ?     1706           
  Partials          ?       64
Impacted Files Coverage Δ
tendrl/node_agent/node_sync/platform_detect.py 25% <ø> (ø)
...s/gluster/heavy_weight/tendrl_gluster_heal_info.py 15.66% <ø> (ø)
tendrl/node_agent/node_sync/network_sync.py 12.71% <0%> (ø)
tendrl/node_agent/tests/objects/test_config.py 75% <0%> (ø)
...de_agent/tests/objects/test_compiled_definition.py 66.66% <0%> (ø)
...ring/collectd/collectors/gluster/tendrl_gluster.py 0% <0%> (ø)
tendrl/node_agent/tests/objects/test_definition.py 69.23% <0%> (ø)
tendrl/node_agent/tests/mock_gluster_state.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f55946...b923dff. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9f55946). Click here to learn what that means. The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #874   +/-   ##
=========================================
  Coverage          ?   41.89%           
=========================================
  Files             ?       72           
  Lines             ?     3046           
  Branches          ?      450           
=========================================
  Hits              ?     1276           
  Misses            ?     1706           
  Partials          ?       64
Impacted Files Coverage Δ
tendrl/node_agent/node_sync/platform_detect.py 25% <ø> (ø)
...s/gluster/heavy_weight/tendrl_gluster_heal_info.py 15.66% <ø> (ø)
tendrl/node_agent/node_sync/network_sync.py 12.71% <0%> (ø)
tendrl/node_agent/tests/objects/test_config.py 75% <0%> (ø)
...de_agent/tests/objects/test_compiled_definition.py 66.66% <0%> (ø)
...ring/collectd/collectors/gluster/tendrl_gluster.py 0% <0%> (ø)
tendrl/node_agent/tests/objects/test_definition.py 69.23% <0%> (ø)
tendrl/node_agent/tests/mock_gluster_state.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f55946...adc2567. Read the comment docs.

GowthamShanmugam commented 5 years ago

@shtripat @nthomas-redhat @dahorak please review, There is 2 different commits in this PR, one for an actual fix and one for upstream pep8 fix

GowthamShanmugam commented 5 years ago

@shtripat Changes done

dahorak commented 5 years ago

What component is configuring the node_id in the collectd configuration files? And is it used anywhere else? Otherwise LGTM.

GowthamShanmugam commented 5 years ago

@dahorak we are not going to read node_id form configuration file, it is not used anywhere