search

Tendrl / specifications

Tendrl specs go here
GNU Lesser General Public License v3.0
6 stars 16 forks source link

Added specification enhance_gluster_cluster_sync_logic.adoc #170

Closed shtripat closed 7 years ago

shtripat commented 7 years ago

tendrl-bug-id: Tendrl/specifications#167 Signed-off-by: Shubhendu shtripat@redhat.com

shtripat commented 7 years ago

@Tendrl/tendrl-core @atinmu @samikshan plz review.

shtripat commented 7 years ago

Looks good for implementation, but I'd suggest addressing some minor concerns such as linking to gluster issues in this spec before merging it.

The references section does have links to glusterfs github issues.

shtripat commented 7 years ago

Does gdeploy also report the up (partial) status? I know it returns up (degraded). I'm asking because if this is a new status that we report, it'll need to be documented to tell the users what it actually means.

up (partial) and up (degraded) are two different states reported for volumes based on calculations. The pseudo code has the logic which decides in what situations the state would be up (degraded)

shtripat commented 7 years ago

The APIs will soon be required, most likely in the Gluster Monitoring milestone. Though, I suggest that for now, we exclude the API details from this spec and file a separate spec or an issue for API endpoints for all the additional gluster state information we now include as part of this spec.

Will remove the entry from this spec. @anivargi please do the needful from API side.

shtripat commented 7 years ago

Would be ideal to link to the gluster issues tracking these changes.

I have gluster github issues in references section. Will move here.