Tendrl / specifications

Tendrl specs go here
GNU Lesser General Public License v3.0
6 stars 16 forks source link

Merge node namespace with Cluster namespace #236

Closed r0h4n closed 6 years ago

r0h4n commented 7 years ago

With the changes lined up for https://github.com/Tendrl/specifications/issues/213

tendrl-node-agent can purely rely on Cluster.is_managed to group cluster nodes under the "clusters/" namespace.

This issue to capture all known and unknowns for this merge

anivargi commented 7 years ago

Here are my thoughts:

To manage cases where we need a list of host across all clusters, we could add a index like node_id : cluster_id, but I don't see the use case for showing this view.

r0h4n commented 7 years ago

@anmolbabu how does @anivargi comment affect monitoring collectors?

brainfunked commented 7 years ago

@r0h4n which milestone is this aimed at?

anmolbabu commented 7 years ago

@r0h4n This doesn't affect me in any way because my atom is invoked automatically as part of import cluster flow.. As long as NS.node_context is intact I am not really affected by this change.. Also, if we are going with above decision is it possible to add a way to indicate the exact peer name as gluster knows in NS.node_context ?? Currently there is a field called fqdn which is just socket.gethostname but in case of nodes with multiple ips we are only interested in details pertaining to cluster network so there this would be helpful.. This is not related to this issue but I just wanted to bring this up

r0h4n commented 7 years ago

@anmolbabu So to summarize

Please file an issue on commons for fqdn change right away

anmolbabu commented 7 years ago

@r0h4n Done https://github.com/Tendrl/commons/issues/687