Open gnehapk opened 6 years ago
@nthomas-redhat @r0h4n @shtripat @julienlim @mcarrano @mbukatov @a2batic @cloudbehl Please review.
@julienlim please review this, we need to close this
@gnehapk @nthomas-redhat @r0h4n @shtripat @julienlim @mcarrano @mbukatov @a2batic @cloudbehl @jjkabrown1
In reviewing the spec, I'd like to suggest adding the following (I'm not able to edit the spec as I don't have permissions to do so):
Introduction The intent of this change is to optimize the user experience and usability for the Tendrl users, i.e. allowing quicker access to managed objects through fewer steps, as well as allowing for dynamic product features (menu items) to be exposed based on a given context (cluster type). Moreover, it allows for easier access to top-level objects (cluster resources) being managed with a given cluster.
Problem Description The Tendrl release 1.5.4 uses a navigation that requires multiple-level drill-down to examine details of objets with a cluster. Its navigation uses a static menu bar on the left with access to top-level objects only via drill-downs in the right pane, which is less than optimal.
To optimize and improve the user experience and usability, we want to introduce a more optimal navigation, whereby we use a Context Selector in the masthead to allow for quickly switching between clusters. Additionally, the left-hand navigation menu bar would be context-sensitive, i.e. the menu is shown in context of a selector cluster, allowing for different menu items (product features) to be presented for different cluster types (e.g. Ceph and Gluster). No navigation bar is shown when all clusters are selected. This is further detailed in Concept B: Single Cluster / Element Manager Concept with Context Switcher Navigation (Optimized UX).
Performance Impact There should be no UI performance impact due to this change.
Acceptance Criteria The following should be satisfied to confirm that this spec is completed and working as intended:
@gnehapk Thanks for adding the items I mentioned. I was hoping you would fill out the rest of the Acceptance Criteria (this is needed for QE to do their testing).
As I don't have push access to the spec, can you please add the rest of the following items under the Acceptance Criteria section? Once they are added, I'll approve the spec.
@r0h4n @Tendrl/tendrl-qe @mcarrano
Just a note. In current version there's no any 'View Details' instead there's 'Track Progress' when the import is running.
@ltrilety Noted with the recent 1.5.5 release. Can you please file a GitHub issue for it? Thanks.
@ltrilety Noted with the recent 1.5.5 release. Can you please file a GitHub issue for it? Thanks.
@julienlim Fine I created https://github.com/Tendrl/ui/issues/812. I was not sure if that's an issue, as I don't much care if there's one or the other. However for sure there is some discrepancy between specification and the current state.
@julienlim @gnehapk I noticed a small discrepancy between design - Concept B and this specification when import fails.
Please unify those.
@ltrilety @gnehapk @mcarrano
Good points @ltrilety. We're going to update the design, and the current thought is to add another column "Hosts" that show the # of hosts, and that would be hyperlinkable to show the list of hosts (hostname + IP address) in a modal at any time. We're going to rearrange the columns to be cluster name, cluster version, managed, hosts, volumes, alerts, volume profiling (for the managed) followed by button(s), and cluster name, cluster version, managed, hosts, message (for the unmanaged) followed by button(s).
@mcarrano will be posting the updates to the design.
I have updated the design per @julienlim 's comment and posted to InVision here: https://redhat.invisionapp.com/share/8QCOEVEY9#/244738628_Clusters
@julienlim @mcarrano @gnehapk @a2batic the design change is fine and I agree with that. however it doesn't solve the discrepancy I mentioned at all.
View Details
link, while this specification says
Cluster, Host, and Volume details are hyperlinked from the object name (and not from a “Details” button)
.
error should be listed in a modal for a failed Import Cluster on clicking "View Details" link.
whilst design states that whole task details should be provided, which makes sense as simple error message doesn't have to be enough for more info see https://github.com/Tendrl/ui/issues/813.BTW current build satisfy specification, in other words there's no hosts listing in the View Detail
modal window and simple error message is displayed in case of import fails.
@ltrilety @gnehapk
The design before concept B was implemented, had "Details" button, which has been replaced by a hyperlink as per the design, "View Details" hyperlink in design is for on-going or failed action.
@julienlim @mcarrano, how the import failure task details should be displayed in import failure modal ?
@a2batic @ltrilety @gnehapk @mcarrano
The original design was to have the import task fail task details in the Import Failure Modal, but since we ended up using the Task Details, we're going with that which still provides the full task details.
We'll remove https://redhat.invisionapp.com/share/8QCOEVEY9#/screens/244738627 to reduce confusion.
We're also making some further design updates based on the https://github.com/Tendrl/documentation/wiki/Architecture-Meeting-Notes for 13 Feb 2018.
The original design was to have the import task fail task details in the Import Failure Modal, but since we ended up using the Task Details, we're going with that which still provides the full task details.
@julienlim I created a new https://github.com/Tendrl/ui/issues/821 for this, I am just hoping I understand your comment correctly.
@gnehapk @julienlim @a2batic
I am redirected to Hosts
page when I am on Volumes
(Events
, Tasks
,...) page for some cluster and I change context to another cluster. Is this the expected behaviour? Shouldn't be user redirected to page relevant to the page that was selected before change of context? E.g. after change of context for Volumes
page there might be rendered Volumes
page for selected cluster (but I see the problem to render pages that are deeper in navigation like bricks for selected hosts or specific tasks).
@fbalak @gnehapk @a2batic @mcarrano
If you are on the Volumes (or any of the left-hand nav bar) for ClusterA, and switch context now to ClusterB, I would expect to see the landing page for ClusterB -- in our case, we don't have a landing page (dashboard) and the closest is the Hosts List.
Therefore no matter where you are in the left-hand nav (e.g. Volumes List, Brick Details, etc.), whenever you switch Clusters, you should expect to see the Hosts page.