search

TenjinInc / procrastinator

Delayed task queues made simple.
https://rubygems.org/gems/procrastinator
MIT License
4 stars 0 forks source link

Rename `#log_inside` #31

Open robinetmiller opened 4 years ago

robinetmiller commented 4 years ago

#log_inside could be misinterpreted as inside-vs-outside.

#log_directory would be a clearer name.

robinetmiller commented 4 years ago

The original intent was to use active verbs for method names (eg. #define_queue instead of #queue).

An alternative solution could be to have a new method that accept all log settings.

Example #log_with(directory: '/var/log', level: :debug)

Or, related to #30 #log_with(directory: '/var/log', level: debug, stdout: true)