Tenma-Server / Tenma

Comic book server with in-browser reader
MIT License
251 stars 31 forks source link

Feature Request: Add option to append comicvine resource id to filename for better matching #63

Open ahahn94 opened 6 years ago

ahahn94 commented 6 years ago

Hi.

As the search-based matching is rather unstable I would suggest you add an option to specify the comicvine api resource id of a volume directly in the filename. This has 2 major advantages over the matching via search:

An example filename of a directory containing a volume could be "Batman (2016) {91273}", with "Batman 2016" being the volume name and year, "91273" being the resource id and "{}" being the delimiters of the id.

A similar approach could be used on the issues aswell. As it would be a rather painful process to gather the resource ids for every single issue, I would propose to use the issue number instead. An example filename of an issue could be "Batman 2016 - Issue 1 {01}".

This would realy help to speed things up and to reduce the time needed to fix bad matches when re-importing a collection.

ahahn94 commented 6 years ago

Another option: Use some kind of config file to identify the volume. Maybe an .ini file with something like:

[Volume]
ID=91273

As the process for obtaining the issue number seems rather solid, just adding the resource id of the volume via the config file should be enough to improve matching and performance a lot. This would be much less invasive than my first suggestion.

Using isfile("volume.ini") and configparser, importing from the .ini file is only about 5 lines of code and can be decided on a per-directory basis, using the information from the directory name if the file is missing.

Sadly I do not have enough free time nor knowledge about Django, so I can not implement this by myself (at least for now).

Please let me know what you think about this.

Greetings from Germany.