search

Tenor-Inc / tenor-android-core

Tenor Android Core
Apache License 2.0
27 stars 10 forks source link

Update Glide and Gradle versions #4

Open Sulfkain opened 6 years ago

Sulfkain commented 6 years ago

Hello, I'm trying to use your lib, but the problem is dependencies are really old. The last version of Glide is 4.7 and you are using 3.8. With gradle happens the same, you are using 3.2.1 while the last is 4.4.

I'm having collision between your dependencies and mines, because im using 4.5 Glide and you need 3.8. Gradle shows the error: Failed to find byte code for com/bumptech/glide/request/target/GlideDrawableImageViewTarget This class was removed from >=v4 from Glide.

Could you please, update this repo with latest dependencies.

Thanks.

gwlove commented 6 years ago

Thanks for reaching out. We are working on this and expect it will take a bit of time for the update to go out. We will update this thread once it's live.

On Wed, Apr 25, 2018 at 7:37 AM, Christian Olcina notifications@github.com wrote:

Hello, I'm trying to use your lib, but the problem is dependencies are really old. The last version of Glide is 4.7 and you are using 3.8. With gradle happens the same, you are using 3.2.1 while the last is 4.4.

I'm having collision between your dependencies and mines, because im using 4.5 Glide and you need 3.8. Gradle shows the error: Failed to find byte code for com/bumptech/glide/request/tar get/GlideDrawableImageViewTarget This class was removed from >=v4 from Glide.

Could you please, update this repo with latest dependencies.

Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Tenor-Inc/tenor-android-core/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWKHLQ936_qL7UM1z8Tv9gWQJyj3CH7ks5tsIpAgaJpZM4TjjqO .

Sulfkain commented 6 years ago

Perfect!, Do you know the stimated time? maybe 1 month?, 2? more? less? Just to know and planning our project.

Thanks you!

gwlove commented 6 years ago

No problem. Two months is likely.

On Fri, Apr 27, 2018 at 1:24 AM, Christian Olcina notifications@github.com wrote:

Perfect!, Do you know the stimated time? maybe 1 month?, 2? more? less? Just to know and planning our project.

Thanks you!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Tenor-Inc/tenor-android-core/issues/4#issuecomment-384901518, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWKHMKBsfAyNao7L53g8YgGstlGqTQBks5tstWkgaJpZM4TjjqO .

Sulfkain commented 6 years ago

Any updated about this?

Thanks!

ctrl-alt-del commented 6 years ago

Hi @Sulfkain

Thanks for reaching out to us. We are still working on a few things on the SDK.

In the meantime, I cherry picked the changes that you need and pushed them to a separate updated_libraries branch.

On that branch, Glide is updated to version 4.7.1 and gradle wrapper is updated to version 4.4. You can build yourself a aar out of that branch using ./gradlew assembleRelease, and grab the aar file from build/outputs/aar/tenor-android-core-release.aar.

Free feel to let me know if you have any questions.

Sulfkain commented 6 years ago

@ctrl-alt-del Thank's! I will try

wvmoreira commented 5 years ago

Hello friend, Are you planning to use the v4 do Glide library?

gwlove commented 5 years ago

Hello friend, Are you planning to use the v4 do Glide library?

Hi @wvmoreira, the message above (here https://github.com/Tenor-Inc/tenor-android-core/issues/4#issuecomment-404341211) remains the best course of action

wvmoreira commented 4 years ago

Hello @gwlove Are you all right? Could you tell me if you still have plans to upgrade to version 4 of Glide?

gwlove commented 4 years ago

Hello @wvmoreira! No changes from the last comment.