Tensegritics / ClojureDart

Clojure dialect for Flutter and Dart
1.42k stars 91 forks source link

Macros defined in ClojureDart cannot reference previously defined functions in same namespace #324

Open dmg46664 opened 10 hours ago

dmg46664 commented 10 hours ago

Describe the bug

Clojure dart is not able to handle this scenario where a function is defined and used in a subsequent macro.

To Reproduce

(defn gensyms [amt]
  (vec (repeatedly amt gensym)))

(defmacro mk-comp-navs []
  ;; rest of fn altered for brevity...
  (gensyms 1)
  )
Syntax error compiling at (test.cljd:14:3).
Faulty form (defmacro mk-comp-navs [] (gensyms 1))

Expected behavior

This should work.

No doubt because of ClojureDart's two phase macro-expansion, it's not aware of the function defined a few lines above.

This is something that is possible in cljs, so presumably the two phases need to work more in parallel than in sequence, or effectively behave as such.

Assume you're aware of cljs quirks https://code.thheller.com/blog/shadow-cljs/2019/10/12/clojurescript-macros.html but these require defining aliases etc.

Additional context

I was trying to convert the specter library and came across a problem running the following code.

Pointing cljd at more clj code will highlight more differences with the language. More reason to champion the following suggestion ;-) https://clojurians.slack.com/archives/C03A6GE8D32/p1729680676173319

I suggest this difference go under the Completeness status of the project given the difference with Clojure core.

cgrand commented 9 hours ago

Add ^:macro-support to the defn name

dmg46664 commented 9 hours ago

@cgrand And for defn- and def (reading between the lines) 😆