Xz/luxor tensor plot - Githubissues

ArrogantGao commented 3 months ago

Add the viz tool LuxorTensorPlot as an extension of the OMEinsumContractionOrders. Two function have been provided, viz_eins plots the tensor network, and viz_contraction generate videos of an contraction order. For more detailed usage, see the revised README.md.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.24691% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.83%. Comparing base (cc2295f) to head (3c3f608). Report is 1 commits behind head on master.

Files	Patch %	Lines
ext/LuxorTensorPlot/src/viz_contraction.jl	80.30%	13 Missing :warning:
src/visualization.jl	0.00%	8 Missing :warning:
ext/LuxorTensorPlot/src/hypergraph.jl	81.57%	7 Missing :warning:
ext/LuxorTensorPlot/src/viz_eins.jl	91.83%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #44 +/- ## ========================================== - Coverage 93.16% 92.83% -0.33% ========================================== Files 13 18 +5 Lines 1097 1270 +173 ========================================== + Hits 1022 1179 +157 - Misses 75 91 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GiggleLiu commented 3 months ago

Please add some tests.

ArrogantGao commented 3 months ago

Added some dependency for the functions defined in src/visualization.jl and making sure they throw ArgumentError if the extension LuxorTensorPlot is not loaded.

ArrogantGao commented 3 months ago

It is strange the the CodeCov seems not working correctly, the revised results are not uploaded properly.

{'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2376s.', code='throttled')}

GiggleLiu commented 3 months ago

I made a few updates, please confirm the changes are reasonable.

ArrogantGao commented 3 months ago

Thanks a lot for your help, I think all changes are reasonable and greatly simplified the code.

GiggleLiu commented 3 months ago

Nice, I just made a minor release here: https://github.com/JuliaRegistries/General/pull/112375

TensorBFS / OMEinsumContractionOrders.jl

Xz/luxor tensor plot #44

Codecov Report