search

TensorBFS / TensorInference.jl

Probabilistic inference using contraction of tensor networks
https://tensorbfs.github.io/TensorInference.jl/
MIT License
18 stars 2 forks source link

UAI reference solution comparison tests #41

Closed mroavi closed 1 year ago

mroavi commented 1 year ago

Solves https://github.com/TensorBFS/TensorInference.jl/issues/35, https://github.com/TensorBFS/TensorInference.jl/issues/38, and partly solves https://github.com/mroavi/Advancing-Probabilistic-Inference-through-Tensor-based-Technology/issues/2 (Only missing UAI Reference Solution Comparison for the PR task)

mroavi commented 1 year ago

PR UAI reference solution comparison ready.

mroavi commented 1 year ago

This change should solve the error you posted.

If you want the readers to use our artifact, you indeed need to tell them to copy this file into their project dir and to include the command that ensures that the artifact gets downloaded (Pkg.ensure_artifact_installed("uai2014", "Artifacts.toml")).

GiggleLiu commented 1 year ago

This change should solve the error you posted.

If you want the readers to use our artifact, you indeed need to tell them to copy this file into their project dir and to include the command that ensures that the artifact gets downloaded (Pkg.ensure_artifact_installed("uai2014", "Artifacts.toml")).

Instead of Pkg.ensure_artifact_installed("uai2014", "Artifacts.toml"), can be build it into our package so that in the documentation we can write:

julia> TensorInference.download_data("uai2014")

julia> TensorInference.load_data("uai2014", name, task)

We still have Artifacts as a dependency, but will not download data automaticall for users.

GiggleLiu commented 1 year ago

I created a new issue and merged your PR first.