search

TensorBFS / TensorInference.jl

Probabilistic inference using contraction of tensor networks
https://tensorbfs.github.io/TensorInference.jl/
MIT License
18 stars 2 forks source link

Precompilation is commented out #64

Open gdalle opened 1 year ago

gdalle commented 1 year ago

Is there a specific reason?

https://github.com/openjournals/joss-reviews/issues/5700

GiggleLiu commented 1 year ago

Yes, the precompilation takes too long and breaks the CI tests.

We added precompilation in this PR: https://github.com/TensorBFS/TensorInference.jl/pull/26

And removed it in the following PR: https://github.com/TensorBFS/TensorInference.jl/pull/48

The reasons to remove precompilation are discussed in the above issues. We will add it back when the precompilation time is acceptable.

gdalle commented 1 year ago

this is non blocking for the review