TensorBFS / TensorInference.jl

Probabilistic inference using contraction of tensor networks
https://tensorbfs.github.io/TensorInference.jl/
MIT License
18 stars 2 forks source link

Code example in paper #76

Closed gdalle closed 1 year ago

gdalle commented 1 year ago

There are a few details i don't understand in the code example:

https://github.com/openjournals/joss-reviews/issues/5700

mroavi commented 1 year ago

Thanks for spotting these! You are right in both cases. We fixed them in the repo's ASIA example (https://github.com/TensorBFS/TensorInference.jl/commit/457960f9e1f7589e2f78f522d85e64dcbb11e493) and in the paper (https://github.com/TensorBFS/TensorInference.jl/commit/8457c6f992a214d5c24f63060faa7bb03a57c786).