Closed gdalle closed 1 year ago
Thanks for spotting these! You are right in both cases. We fixed them in the repo's ASIA example (https://github.com/TensorBFS/TensorInference.jl/commit/457960f9e1f7589e2f78f522d85e64dcbb11e493) and in the paper (https://github.com/TensorBFS/TensorInference.jl/commit/8457c6f992a214d5c24f63060faa7bb03a57c786).
There are a few details i don't understand in the code example:
In[4]
: when we assume the X-ray is positive, why does it correspond toDict(7 => 0)
In[7]
: the phrasing is a bit ambiguous, there is only one most probable outcome which has several variables (and by the way, variables 3 and 4 are zero in this one)https://github.com/openjournals/joss-reviews/issues/5700