search

TensorSpeech / TensorFlowTTS

:stuck_out_tongue_closed_eyes: TensorFlowTTS: Real-Time State-of-the-art Speech Synthesis for Tensorflow 2 (supported including English, French, Korean, Chinese, German and Easy to adapt for other languages)
https://tensorspeech.github.io/TensorFlowTTS/
Apache License 2.0
3.8k stars 810 forks source link

Error german_transliterate only when using german_cleaners #748

Closed NeonBohdan closed 2 years ago

NeonBohdan commented 2 years ago

To use TensorflowTTS I need to install german_transliterate using pip install git+https://github.com/repodiac/german_transliterate.git#egg=german_transliterate Even if I don't need german_cleaners

This limits me to create PyPi package that uses TensorflowTTS as dependency as german_transliterate has licence problems

The solution is to throw error message on use stage instead of import stage So you don't need to install german_transliterate when you don't use it

Please create 1.8.1 version with this fix as this issue is enough frequent

It may solve next issues https://github.com/TensorSpeech/TensorFlowTTS/issues/682 https://github.com/TensorSpeech/TensorFlowTTS/issues/594 https://github.com/TensorSpeech/TensorFlowTTS/issues/580 https://github.com/TensorSpeech/TensorFlowTTS/issues/567 https://github.com/TensorSpeech/TensorFlowTTS/issues/454

NeonDaniel commented 2 years ago

Is there/can there be a PyPI release that includes this commit?