search

TensorStack-AI / OnnxStack

C# Stable Diffusion using ONNX Runtime
Apache License 2.0
221 stars 33 forks source link

Add reference to original stable diffusion repo, blog and tutorial #59

Closed cassiebreviu closed 11 months ago

cassiebreviu commented 11 months ago

Hey! This implementation of the stable diffusion C# work I did is great. I would appreciate if you included a reference to the original repo that I created and the blog and tutorial I published. Thanks! Cassie

saddam213 commented 11 months ago

Unfortunately I have not seen the blog post you and your friend made so dont feel its right to use it as a refernce as I dont know what its about

cassiebreviu commented 11 months ago

The blog post and tutorial are what I wrote to promote the work I did for my C# stable diffusion repo which you used to create this. The blog and tutorial (which are linked in this pr) explain how I implemented the logic to create SD in pure C#. Its a great resource for people to understand how SD actually works. And its respectful to give credit where credit is due.

saddam213 commented 11 months ago

Sorry if I was unclear, I am very happy adding attribution to you SD repo as it was extremely helpful understanding the TextToImage process using Onnx and C#

But regarding the blog post, I would have to read it first sorry, I cant reference/endorse blogs/articles that I have not read, hope you understand

I actually assumed you did not want to be affiliated with my work as you ignored all my PR's to add this functionality to your own repo, then started deleting comments I made in your repo when I was trying help your users implement ImageToImage, that gave me a clear message my code was ether garbage or you were uninterested, I'm just a T-Shirt Printer, you work at Microsoft, so its hard to gauge if my contributions were any help or not

I see you still have not merged ay of those PRs? If you do I have a lot more to add, like ImageToImage, InPaint, Realtime SD and updating to the OrtValue API as the one in you repo is now depreciated, these are blocked behind the large maintenance PR I did PR29

cassiebreviu commented 11 months ago

I see, thanks for the clarification. No shade to your code. Its looking great, as I said in the original comment. I didnt have time/interest in maintaining the original one as an open-source project and I probably should have indicated that it is "as is" in the readme. Lesson learned. The blog posts literally just explain the code. I have removed the blog post and left the onnxruntime.ai tutorial and reference. Let me know if that works for you. Thanks!