Teoge / MarkToolForParkingLotPoint

A tool for parking-slot labeling under surround-view image
GNU General Public License v3.0
80 stars 24 forks source link

Save the marking points #1

Closed chokkarapu closed 4 years ago

chokkarapu commented 4 years ago

Hello teogo,

Thanks for providing the tool for researchers. hen I tried to use tool, after i Mark the points i got .mat file and then used mat2json scrip to convert . I even got the .json file...

But the .json file which u provided in DMPR paper dataset-json file, has [x1,y1,x2,y2,0/1] as marks, but when i generated i got only [x1,y1] as marks.

Could u kindly provide how to generate the .json file format of yours. I look forward for prompt reply.

Thanks, Anil.

Teoge commented 4 years ago

Hello, Anil.

This repository has two branches, master branch and directional_point branch.

The master branch is intended for the labeling in the method "DeepPS", published in the paper "Vision-based Parking-slot Detection: A DCNN-based Approach and A Large-scale Benchmark Dataset"

And the directional_point branch is used for the labeling in "DMPR-PS".

This is because labeling in "DMPR-PS" is different from the labeling in "DeepPS". "DMPR-PS" requires more label information, which is the direction of each marking-point.

If you want to prepare your own dataset for "DMPR-PS", you need to use directional_point branch to label your images.

One more thing is that the README.md at directional_point branch is out-of-date. But you could easily figure out how to use it. It's similar to master branch. I'll update the README.md in the future.

chokkarapu commented 4 years ago

@Teoge : Thanks for your prompt reply....And giving more information...I will try to use use directional_point branch . Will understand ur data set preparation by spending efficient time, i will revert back for any clarification.

Thanks, Anil.

chokkarapu commented 4 years ago

Hi Teoge,

I have cloned @directional_point branch. Understood to maximum. My understating are follows, 1) For T-Shaped, the direction is towards inside slot, as shown below, t_Shaped

Im totally confused with direction when marking as L_Shaped, For below image u have taken direction as follow, L_Shaped_Right

Where as for other image (L_Shaped) u have taken direction as shown below: image Whereas for other image(L-Shaped), u considered following direction as shown below: image

So im totally confused with this set of labeling... I request you to provide some details in takeing direction for L-Shaped especially...

I eagerly look forward for your response....

Thanks, Anil.

Teoge commented 4 years ago

The definition of orientations of L-shaped marking-points is presented in our paper DMPR-PS: A Novel Approach for Parking-Slot Detection Using Directional Marking-Point Regression.

In short, we define the orientation of a L-shaped marking-point as the direction along the marking-line that overlaps with the other marking-line after 90◦ clockwise rotation.

Following figure might help you understand the definition.

l-shaped_illustration

chokkarapu commented 4 years ago

Thank U Teogo for making more clear understanding.

I have following two qeuries, kindly provide some information: 1) Have you ever tried with Open Slot type of Parking Slot as shown below, image

2) If I want to add one more type as Open shape, i.e. i will add 2 as point shape along with 0-T shaped and 1-LShaped, with addition of one more new shape your base code will work or need to modify any particular place of your code...

Thanks for your valuable tie.

Thanks, Anil.

Teoge commented 4 years ago

Hello, Anil.

  1. For your first question, the short answer is no. We collected our data in China, where parking-slots of open slot type are rarely seen. Thus we don't have enough samples to perform related experiments.
  2. For your second question, if the "code" you mentioned is the code of this labeling tool, then yes, basically the code will work, as long as you add the shape correctly (which includes modifications of data structure, UI that sets marking-point type, and the corresponding UI callback function). If the "code" you mentioned is the code of DMPR-PS, then the answer is no. Except for adding a new type, you'll need to modify the logic of marking-point pairing and lots of related stuff, in order to make it work on open slot type parking-slot detection.