search

Teradata / PyTd

A Python Module to make it easy to script powerful interactions with Teradata Database in a DevOps friendly way.
MIT License
108 stars 43 forks source link

TD Error message fix for batch mode #105

Closed sband closed 6 years ago

sband commented 6 years ago

fixes #100

sband commented 6 years ago

@escheie could you please review this code so that this can be merged

escheie commented 6 years ago

Thanks for the contribution. I've confirmed all unit tests are passing for this change. I will target having this reviewed and merged before the end of the week.

escheie commented 6 years ago

After investigating #100, it actually looks like the problem is with TDREST returning HTTP status code 200 instead of 420. Your workaround looks good but I want to confirm with the TDREST team if this should be fixed on their side.

sband commented 6 years ago

ok so if this is a TDREST issue, do we merge this pull request or should we just close this ?

escheie commented 6 years ago

While the workaround works well for this particular case it could prevent future parsing errors from being reported correctly. Therefore I'm hesitant to merge this change and would rather resolve via the TDREST fix.

sband commented 6 years ago

Closing this pull request as we wait for TDREST to fix this issue.